[dev] [surf] revision 175 breaks proxy support

From: anonymous <aim0shei_AT_lavabit.com>
Date: Wed, 10 Mar 2010 23:12:22 +0300

Revision 175 of surf removed lines 158-162:

/* cookie persistance */
s = webkit_get_default_session();
cookies = soup_cookie_jar_new();
soup_session_add_feature(s, SOUP_SESSION_FEATURE(cookies));
g_signal_connect(cookies, "changed", G_CALLBACK(changecookie), NULL);

Then variable `s` is used again in code that is related to proxy support,
so removing of its initialisation breaks proxy support.

Obvious fix for revision 177:

diff -r 688bf1f96927 surf.c
--- a/surf.c Mon Mar 08 10:06:32 2010 +0100
+++ b/surf.c Wed Mar 10 23:08:27 2010 +0300
@@ -697,6 +697,8 @@
         scriptfile = buildpath(scriptfile);
         stylefile = buildpath(stylefile);
 
+ s = webkit_get_default_session();
+
         /* proxy */
         if((proxy = getenv("http_proxy")) && strcmp(proxy, "")) {
                 new_proxy = g_strrstr(proxy, "http://") ? g_strdup(proxy) :
Received on Wed Mar 10 2010 - 20:12:22 UTC

This archive was generated by hypermail 2.2.0 : Wed Mar 10 2010 - 20:24:02 UTC