Re: [dev] st patch: rectangular selection support

From: Alexander Sedov <alex0player_AT_gmail.com>
Date: Tue, 19 Feb 2013 22:25:07 +0400

Enjoy these well-formed patches.


2013/2/19 Alexander Sedov <alex0player_AT_gmail.com>

> Here it is, the new version.
>
>
> 2013/2/19 Christoph Lohmann <20h_AT_r-36.net>
>
>> Greetings.
>>
>> On Tue, 19 Feb 2013 15:54:06 +0100 Alexander Sedov <alex0player_AT_gmail.com>
>> wrote:
>> > This patch adds support for rectangular selections a-la urxvt, which
>> come
>> > in handy when using applications like irssi or mcabber.
>>
>> You are commenting out code and leave it there without any notice, if it
>> should be reused later. Next you are using a different style than the st
>> style, which means you use Ľif (ę instead of Ľif(ę. The same applies for
>> the switch case and the simple if clause, which should be
>>
>> if() {
>> } else {
>> }
>>
>> If thatís fixed your patch will be applied. The hard case why Iím not
>> applying it and notice you is because of commenting out the code. Thatís
>> unclean.
>>
>>
>>
>> Sincerely,
>>
>> Christoph Lohmann
>>
>>
>>
>

Received on Tue Feb 19 2013 - 19:25:07 CET

This archive was generated by hypermail 2.3.0 : Thu Feb 21 2013 - 19:24:32 CET