Re: [dev] [PATCH] Fix selecting clearing and BCE

From: Alexander Sedov <alex0player_AT_gmail.com>
Date: Wed, 24 Apr 2013 02:45:45 +0400

2013/4/24 Roberto E. Vargas Caballero <k0ga_AT_shike2.com>:
> You are talking here about our Selection data structure, and you are right,
> if we mark it as not enabled (sel.bx = -1), all the problem will be fixed,
> and maybe in a cleaner way.
> We can test it in tclearregion in this form:
>
>
>
> for(y = y1; y <= y2; y++) {
> term.dirty[y] = 1;
> for(x = x1; x <= x2; x++) {
> if(selected(y, x))
> selclear(NULL);
> term.line[y][x] = term.c.attr;
> memcpy(term.line[y][x].c, " ", 2);
> }
> }
>
>
> If all the people like this solution, I can send the patch.
Too late -- I already sent almost that exact patch :P.
Yes, I think this is the right thing to do, because st currently
clears selection on putting character inside it. So, changing a
characted with tclearregion() should clear it as well.
Received on Wed Apr 24 2013 - 00:45:45 CEST