Re: [dev] [st] [PATCH] Fix some bugs in mouse tracking logic

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Thu, 1 Aug 2013 10:10:23 +0200

> * Button number in X10 mode:
>
> I believe the button - 1 came from "C b is button - 1" from [0].
> However, above this section, it states
>
> "Normally, parameters (such as pointer poisition and button number)
> for all mouse tracking escape sequences generated by xterm encode
> numeric parameters in a single character as value+32. For example, !
> specifies the value 1."
>
> Also, from the description of SGR,
>
> "The encoded button value in this case does not add 32 since that
> was useful only in the X10 scheme for ensuring that the byte
> containing the button value is a printable code."
>
> This suggests that we should still add 32 to the button value when in
> MODE_MOUSEX10.

It is no clear for me if we have to add it or not, did you test it with
other emulators?

-- 
Roberto E. Vargas Caballero
----------------------------
k0ga_AT_shike2.com
http://www.shike2.com
Received on Thu Aug 01 2013 - 10:10:23 CEST

This archive was generated by hypermail 2.3.0 : Thu Aug 01 2013 - 10:12:06 CEST