[dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

From: Mark Edgar <medgar123_AT_gmail.com>
Date: Sun, 6 Oct 2013 12:24:16 +0200

Oh, and let's do the same for Mousekey while we're at it.

     -Mark


Avoid buffer overrun in bpress().
Use correct type for Mousekey.b (XButtonEvent.button).

--- a/st.c
+++ b/st.c
_AT_@ -256,9 +256,9 @@ typedef struct {
 } XWindow;

 typedef struct {
- int b;
+ uint b;
  uint mask;
- char s[ESC_BUF_SIZ];
+ char *s;
 } Mousekey;

 typedef struct {
Received on Sun Oct 06 2013 - 12:24:16 CEST