Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

From: sin <sin_AT_2f30.org>
Date: Thu, 10 Oct 2013 22:02:14 +0300

On Thu, Oct 10, 2013 at 08:56:05PM +0200, Roberto E. Vargas Caballero wrote:
> > It's runtime segfault (that may be rare and hard to catch) that is
> > worth exactly one additional check.
>
> Ok, we don't agree about this topic, so I would like listen the opinion
> of other suckless developers in order to take a decision.

I agree with Roberto here, if a user makes a mistake in the configuration
and the program segfaults it is the user's responsibility.

I do not think it is hard to catch, all it takes is to diff your config
against a known working copy (the default one for example).

Thanks,
sin
Received on Thu Oct 10 2013 - 21:02:14 CEST