Re: [dev][ubase][PATCH] swapon/swapoff -a and -p

From: sin <sin_AT_2f30.org>
Date: Sun, 9 Feb 2014 11:11:15 +0000

On Sat, Feb 08, 2014 at 10:34:31PM -0500, Carlos Torres wrote:
> Hi sin,
> attached are two patches for the -a flag on swapon and swapoff. there
> is room for improvement. and cleaning up, but i wasn't sure how you
> might want it organized. i altered the error handling a little bit,
> since it felt funny how you let the loop continue on error and
> possibly removing the EXIT_FAILURE return code if two devices are to
> be swapped on/off and the first failed but the second succeeds. I
> make it so that once EXIT_FAILURE is set it doesn't go away.

Thanks a lot for your patches. They have been applied.

(You are right btw about setting the exit value.)

Cheers,
sin
Received on Sun Feb 09 2014 - 12:11:15 CET