Re: [dev] [st] [PATCH] Refactor xsetcolorname()

From: FRIGN <>
Date: Sun, 1 Jun 2014 17:51:35 +0200

On Sun, 01 Jun 2014 16:20:44 +0200
Christoph Lohmann <> wrote:

> The xsetcolorname() function should be conservative in its input. Since
> it is only called from escape input it shouldn’t overwrite a dc.col if
> something failed. I fixed this and refactored to the function according
> to your patch, which removed the temporary variables.

It wouldn't overwrite dc.col's adress in case something fails
internally, but it is a memleak the way I did it, because dc.col is not
freed before being re-assigned.



Received on Sun Jun 01 2014 - 17:51:35 CEST

This archive was generated by hypermail 2.3.0 : Sun Jun 01 2014 - 18:00:08 CEST