[dev] [PATCH] Fixed embedding when given Window id is zero

From: <quinq.ml_AT_gmail.com>
Date: Wed, 15 Oct 2014 13:49:34 +0200

From: Quentin Rameau <quinq_AT_quinq.eu.org>

Patch letting st not embedding when given Window id is zero, without failing.

---
 st.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/st.c b/st.c
index c61b90a..1b419c8 100644
--- a/st.c
+++ b/st.c
_AT_@ -3134,8 +3134,8 @@ xinit(void) {
 		| ButtonMotionMask | ButtonPressMask | ButtonReleaseMask;
 	xw.attrs.colormap = xw.cmap;
 
-	parent = opt_embed ? strtol(opt_embed, NULL, 0) : \
-			XRootWindow(xw.dpy, xw.scr);
+	if (!(opt_embed && (parent = strtol(opt_embed, NULL, 0))))
+		parent = XRootWindow(xw.dpy, xw.scr);
 	xw.win = XCreateWindow(xw.dpy, parent, xw.l, xw.t,
 			xw.w, xw.h, 0, XDefaultDepth(xw.dpy, xw.scr), InputOutput,
 			xw.vis, CWBackPixel | CWBorderPixel | CWBitGravity
-- 
2.1.2

Received on Wed Oct 15 2014 - 13:49:34 CEST