Re: [dev] My dmenu patches

From: Eric Pruitt <eric.pruitt_AT_gmail.com>
Date: Sat, 18 Apr 2015 08:51:51 -0700

On Sat, Apr 18, 2015 at 10:30:37AM +0200, Hiltjo Posthuma wrote:
> You seem to have based your second patch on dmenu 4.5, not on git. You
> should always use the latest git version. I can't reproduce the bug on
> the latest git version.

You seem to have not read the other thread involving this bug; that
patch was created on top of the Git HEAD:

    commit 8ee135bb6a8997d5e552f235c7c47ff85b741bcb
    Author: Eric Pruitt <eric.pruitt_AT_gmail.com>
    Date: Sun Apr 12 11:41:42 2015 -0700

        Add flag to automatically print unambiguous query

        - The "-a" flag has been added which causes dmenu to immediately print
          and exit if only one entry matches the current query.

    commit 13a529ce63364544bdc851dfd5d3aa2ef8740914
    Author: Anselm R Garbe <garbeam_AT_gmail.com>
    Date: Wed Sep 17 13:40:11 2014 +0200

        applied Hiltjo's patch as suggested on the ml to fix ControlMask for C-j and C-m

If you look at the other thread noname_AT_inventati.org was also not able
to reproduce the problem I encountered, but Markus Teich was per
http://lists.suckless.org/dev/1504/26295.html, so I am not the only
person the bug affects. If the patch doesn't break any functionality for
you, then I don't think there's any harm in applying the patch.

Eric
Received on Sat Apr 18 2015 - 17:51:51 CEST

This archive was generated by hypermail 2.3.0 : Sat Apr 18 2015 - 18:00:10 CEST