Re: [hackers] [dwm] I didn't knew of c->isfixed, that should fix Jukkas issue with gkrellm ; )

On Sat, Feb 17, 2007 at 07:32:47PM +0100, Jukka Salmi wrote:
> Jukka Salmi --> dwm (2007-02-17 15:21:43 +0100):
> > Jukka Salmi --> dwm (2007-02-14 22:04:41 +0100):
> > > Anselm R. Garbe --> hackers (2007-02-13 21:57:01 +0000):
> > > > changeset: 755:887d74605df8
> > > > tag: tip
> > > > user: Anselm R. Garbe <arg_AT_suckless.org>
> > > > date: Tue Feb 13 22:53:58 2007 +0100
> > > > summary: I didn't knew of c->isfixed, that should fix Jukkas issue with gkrellm ;)
> > >
> > > It does, thanks a lot!
> >
> > Revision 762 introduced a similar problem: when trying to start gkrellm
> > in the bottom right corner (`gkrellm -geometry -0-0'), gkrellm appears
> > in the top left corner, but as soon as I try to move the window (MODKEY
> > + left button) it "jumps" to the bottom right corner... Any hints?
>
> Additionally, since rev 762 gkrellm doesn't resize anymore if e.g. a
> network interface is brought up (which causes a new monitor to be drawn
> inside the gkrellm window, increasing the windows height) until I use
> the mouse to move the window. The attached patch works around the
> problem; not sure how to fix it correctly, though.
>
> Regards, Jukka
>
> --
> bashian roulette:
> $ ((RANDOM%6)) || rm -rf ~

> diff -r 759a5fbbd8b7 client.c
> --- a/client.c Fri Feb 16 16:51:27 2007 +0100
> +++ b/client.c Sat Feb 17 19:20:20 2007 +0100
> @@ -267,7 +267,7 @@ resize(Client *c, int x, int y, int w, i
> x = sx;
> if(y + h + 2 * c->border < sy)
> y = sy;
> - if(c->x != x || c->y != y || c->w != w || c->h != h) {
> + if((c->isfloat || arrange==dofloat) || (c->x != x || c->y != y || c->w != w || c->h != h)) {
> c->x = wc.x = x;
> c->y = wc.y = y;
> c->w = wc.width = w;

This doesn't fix the real problem, I pushed a change which
should fix the real problem.

Regards,

-- 
 Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361