Re: [dwm] Fibonacci patch ported to 4.6

From: Anselm R. Garbe <>
Date: Fri, 12 Oct 2007 10:09:51 +0200

On Fri, Oct 12, 2007 at 09:57:19AM +0200, Xavier wrote:
> On Thu, Oct 11, 2007 at 08:49:08PM +0200, Anselm R. Garbe wrote:
> > I recreated dwm.h which includes the Client struct definition yet again.
> > Lemme know if you believe that other definitions might be useful
> > as well.
> >
> Apparently, fibonacci layout also needs other definitions indeed.
> I just moved them from dwm.c to dwm.h like you did for Client struct. I'm
> attaching a patch for it, as well as a new fibonacci patch using dwm.h.
> But what about other layouts? Knowing which definitions belong to dwm.h
> because they might be useful for other layouts probably requires a good
> understanding of the codebase :)

Well, I'd prefer that declare the stuff you need from dwm.c as
externals, simply because they aren't declared as static there.

At the beginning of fibonacci.c or .h add:

extern Client *nexttiled(Client *c);
extern int screen, sx, sy, sw, sh, wax, way, waw, wah;
extern Client *clients;

Then there is no need to put them into dwm.h. The only annoying
thing is that all extension need to include the Client
definition imho.


 Anselm R. Garbe >< >< GPG key: 0D73F361
Received on Fri Oct 12 2007 - 10:09:52 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 14:59:23 UTC