Re: [dwm] using bitaray for tags (PATCH)

From: Szabolcs Nagy <nszabolcs_AT_gmail.com>
Date: Wed, 21 May 2008 09:23:25 +0200

On 5/21/08, Enno Gottox Boland <gottox_AT_gmail.com> wrote:
> Here's my version of a bitarray patch. Please review and comment.

in config.h referencing tags has changed in rules but not in keys.

the (1 << tagnum) in rules is a bit nasty
it is probably nicer to do the shifting in setup();

instead of
 i < LENGTH(tags) && i < sizeof(int) * 8;
what about checking once
 if(LENGTH(tags) > sizeof(int) * CHAR_BIT)
     eprint("Maximum number of tags: %d\n", sizeof(int) * CHAR_BIT);
in setup();
Received on Wed May 21 2008 - 09:23:27 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 15:42:58 UTC