Re: [dwm] [patch] spawn without shell

On Thu, Jun 12, 2008 at 10:18:07AM +0200, Henrik Holst wrote:
> On Wed, Jun 11, 2008 at 12:00:02PM +0200, dwm-request_AT_suckless.org wrote:
> > Date: Wed, 11 Jun 2008 10:17:03 +0200
> > From: "Anselm R. Garbe" <arg_AT_suckless.org>
> > Subject: Re: [dwm] [patch] spawn without shell
> > To: dynamic window manager <dwm_AT_suckless.org>
> > Message-ID: <20080611081703.GG15776_AT_suckless.org>
> > Content-Type: text/plain; charset=us-ascii
> >
> > On Mon, Jun 09, 2008 at 02:57:30PM +0200, Peter Hartlich wrote:
> > > I've attached a patch against hg tip that makes spawn() use a
> > > NULL-terminated char pointer array for the argument, which is
> > > execvp'd directly instead of going through the shell.
> >
> > I consider integrating your patch as well before 5.0 to get rid
> > of major upgrades to config.h after 5.0. I will have a look
> > tonight into this.
> >
>
> This will change user environment for launched programs.
>
> However, it is probably more consistent with gmrun, gnome run and avoids
> any portability issues dwm has had before with different shells.

Well there is a new SHCMD macro in config.def.h to aim the old
behavior with the new spawn, if one uses a different shell to
/bin/sh, just change that macro to meet your shell if you use it
at all.

Kind regards,

-- 
 Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361