Re: [dwm] [patch] Minor code cleanup

On (13/08/08 17:10), Martin Hurton wrote:
> To: dwm_AT_suckless.org
> From: Martin Hurton <martin.hurton_AT_gmail.com>
> Subject: Re: [dwm] [patch] Minor code cleanup
> Mail-Followup-To: dwm_AT_suckless.org
> Reply-To: dwm mail list <dwm_AT_suckless.org>
> List-Id: dwm mail list <dwm.suckless.org>
> User-Agent: Mutt/1.5.18 (2008-05-17)
>
> On Wed, Aug 13, 2008 at 04:43:46PM +0200, Premysl Hruby wrote:
> > On (13/08/08 16:21), Enno Gottox Boland wrote:
> > > To: dwm mail list <dwm_AT_suckless.org>
> > > From: Enno Gottox Boland <gottox_AT_gmail.com>
> > > Subject: Re: [dwm] [patch] Minor code cleanup
> > > Reply-To: dwm mail list <dwm_AT_suckless.org>
> > > List-Id: dwm mail list <dwm.suckless.org>
> > >
> > > Hi!
> > >
> > > 2008/8/13, Martin Hurton <martin.hurton_AT_gmail.com>:
> > > > Can arg really ever be NULL?
> > > no, that should not be possible anymore. the patch is ok so far.
> > > > Cheers,
> > >
> > > regards
> > > Gottox
> > >
> >
> > But that is NOT true, actually view() is called with NULL param, for
> > "select previously selected view" function: (excerpt from tip's
> > config.def.h)
> >
> > { MODKEY, XK_Tab, view, {0} },
>
> That zero does not mean NULL pointer; it is there to initialize the
> Arg structure.
>
> /Martin
>

Hm, that's true, but I'm sure that dwm crashed without check if arg is
not null (in view()).

-Ph

-- 
Premysl "Anydot" Hruby, http://www.redrum.cz/