Re: [dwm] applyrules

From: Filippo Erik Negroni <f.e.negroni_AT_googlemail.com>
Date: Fri, 29 Aug 2008 11:14:38 +0100

2008/8/29 Anselm R Garbe <garbeam_AT_gmail.com>

> Hi Filippo,
>
> 2008/8/27 Filippo Erik Negroni <f.e.negroni_AT_googlemail.com>:
> > In applyrules(), the return value of XGetClassHint is not checked.
>
> Agreed.
>
>
If XGetClassHint is not successful, you cannot make any assumptions about
the values of ch's members.
They might not be NULL, yet the function failed mid way retrieving the
values and left your structure with undefined values.
I believe we must at least return False if XGetClassHint fails.
Received on Fri Aug 29 2008 - 10:14:38 UTC

This archive was generated by hypermail 2.2.0 : Fri Aug 29 2008 - 10:24:04 UTC