[hackers] [st] tresize: move for loop outside if || noname_AT_inventati.org

From: <git_AT_suckless.org>
Date: Tue, 14 Apr 2015 09:56:42 +0200 (CEST)

commit 6352502d644d8295ceb2cdf68a5ecbac0891d4a6
Author: noname_AT_inventati.org <noname_AT_inventati.org>
Date: Sat Apr 11 19:29:52 2015 +0200

    tresize: move for loop outside if
    
    There is no need to check that slide > 0 before executing loop.
    If slide <= 0, loop stops immediately.

diff --git a/st.c b/st.c
index 4ed8319..fb37eb5 100644
--- a/st.c
+++ b/st.c
_AT_@ -2780,17 +2780,16 @@ tresize(int col, int row) {
         }
 
         /* free unneeded rows */
- i = 0;
+ for(i = 0; i < slide; i++) {
+ free(term.line[i]);
+ free(term.alt[i]);
+ }
         if(slide > 0) {
                 /*
                  * slide screen to keep cursor where we expect it -
                  * tscrollup would work here, but we can optimize to
                  * memmove because we're freeing the earlier lines
                  */
- for(/* i = 0 */; i < slide; i++) {
- free(term.line[i]);
- free(term.alt[i]);
- }
                 memmove(term.line, term.line + slide, row * sizeof(Line));
                 memmove(term.alt, term.alt + slide, row * sizeof(Line));
         }
Received on Tue Apr 14 2015 - 09:56:42 CEST