[hackers] [sbase] [PATCH 2/3] find: Fix flushing input buffer with -ok

From: Wolfgang Corcoran-Mathe <first.lord.of.teal_AT_gmail.com>
Date: Mon, 15 Jun 2015 15:27:37 -0400

The original flush-stdin loop (with fgets()) hung until the user
entered some extraneous characters for it to kill.

emg's FIXME about nulls still applies.

---
 find.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/find.c b/find.c
index a870a90..3871105 100644
--- a/find.c
+++ b/find.c
_AT_@ -408,16 +408,16 @@ pri_ok(struct arg *arg)
 {
 	int status, reply;
 	pid_t pid;
-	char ***brace, buf[256];
+	char ***brace, c;
 	struct okarg *o = arg->extra.p;
 
 	fprintf(stderr, "%s: %s ?", *o->argv, arg->path);
 	reply = fgetc(stdin);
 
 	/* throw away rest of line */
-	while (fgets(buf, sizeof(buf), stdin) && *buf && buf[strlen(buf) - 1] == '\n')
+	while ((c = fgetc(stdin)) != '\n' && c != EOF)
 		/* FIXME: what if the first character of the rest of the line is a null
-		 * byte? probably shouldn't juse fgets() */
+		 * byte? */
 		;
 
 	if (feof(stdin)) /* FIXME: ferror()? */
-- 
2.3.5

Received on Mon Jun 15 2015 - 21:27:37 CEST