Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Fri, 3 Jun 2016 19:31:57 +0200

On Fri, Jun 03, 2016 at 06:55:36PM +0200, Markus Teich wrote:
> Hiltjo Posthuma wrote:
> > I noticed a regression, dmenu seems really slow to load on my machine in the
> > function readstdin(). Was the font cache behaviour removed from drw?
>
> Heyho,
>

Heya!,

> that is probably because of the second change noted from readstdin():
>
> I don't see how your patch fixes the slowness, since it still calculates the
> actual width of every item in readstdin().

That's true, it is not the right fix for this issue atleast.

> ...
> I tested
> drw_font_getexts instead of TEXTW, which seems to be a lot faster, but is not as
> accurate, since it doesn't account for fallback fonts if they are needed in the
> string. Please try the attached dmenu patch and let me know if the slowness
> problem is fixed.
>
> --Markus

Your patch fixes the slowness for me, but we need to think of a more accurate
but faster way indeed.

-- 
Kind regards,
Hiltjo
Received on Fri Jun 03 2016 - 19:31:57 CEST

This archive was generated by hypermail 2.3.0 : Fri Jun 03 2016 - 19:36:15 CEST