Re: [hackers] [st][PATCH] Make config.h depend on config.def.h

From: Laslo Hunhold <dev_AT_frign.de>
Date: Fri, 2 Dec 2016 20:04:50 +0100

On Fri, 02 Dec 2016 11:58:07 -0700
Bob Uhl <buhl_AT_zvelo.com> wrote:

Hey Bob,

> How come? At least in my own workflow, I've been surprised by an
> uncopied config.h repeatedly. My expectation is that if I change a
> source file (e.g. config.def.h) that config.h will be updated.

config.def.h contains the default settings. Of course you can change
the defaults, but from a general perspective, it should remain
unchanged.

> But I always make my customisation changes to config.def.h and let git
> merge DTRT when upstream changes things. I can see that if someone
> makes them to config.h and manually copies over new config options
> then he'd be surprised.

Yes that's exactly the point. If I have a git-repo and a nice,
fine-tuned config.h and do a git pull that pulls in config.def.h
changes. When I run make, my config.def is overwritten and lost
forever. This sucks.

> Is this just a case where I'm not understanding how most folks are
> performing their customatisations?

See above.

Cheers

Laslo

-- 
Laslo Hunhold <dev_AT_frign.de>
Received on Fri Dec 02 2016 - 20:04:50 CET

This archive was generated by hypermail 2.3.0 : Fri Dec 02 2016 - 20:12:16 CET