Re: [hackers] [sbase] [PATCH 06/10] xinstall: Check result of fchmod

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Mon, 5 Dec 2016 14:24:07 +0100

On Mon, Dec 5, 2016 at 6:55 AM, Michael Forney <mforney_AT_mforney.org> wrote:
> ---
> xinstall.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

LGTM

> diff --git a/xinstall.c b/xinstall.c
> index bf921fb..5a0e390 100644
> --- a/xinstall.c
> +++ b/xinstall.c
> _AT_@ -119,7 +119,8 @@ install(const char *s1, const char *s2, int depth)
> }
> concat(f1, s1, f2, s2);
>
> - fchmod(fileno(f2), mode);
> + if (fchmod(fileno(f2), mode) < 0)
> + eprintf("fchmod %s:", s2);
>
> if (fclose(f2) == EOF)
> eprintf("fclose %s:", s2);
> --
> 2.11.0
>
>
Received on Mon Dec 05 2016 - 14:24:07 CET

This archive was generated by hypermail 2.3.0 : Mon Dec 05 2016 - 14:36:15 CET