Re: [hackers] [sbase] [PATCH 04/10] Don't use buffered IO (fread) when not appropriate

From: Laslo Hunhold <dev_AT_frign.de>
Date: Tue, 6 Dec 2016 12:51:30 +0100

On Tue, 6 Dec 2016 10:26:22 +0100
Silvan Jegen <s.jegen_AT_gmail.com> wrote:

Hey Silvan,

> It only compiled for me because "util.h" includes stdio.h so the
> definitions are included already. We can still remove this include if
> we don't want it to be included twice but I don't know which approach
> is preferred here.

we definitely need to include it here as your implementation does not
represent everyone's implementation. If Posix demands to include
something for a given function, we should include it.

Cheers

Laslo

-- 
Laslo Hunhold <dev_AT_frign.de>
Received on Tue Dec 06 2016 - 12:51:30 CET

This archive was generated by hypermail 2.3.0 : Tue Dec 06 2016 - 13:00:17 CET