Re: [hackers] [st] Refactoring (-61 lines)

From: Devin J. Pohly <>
Date: Wed, 4 Oct 2017 00:15:35 -0500

On Sun, 1 Oct 2017 at 14:16:26 +0200, Hiltjo Posthuma wrote:
> Regarding the patch: [st][PATCH 05/23] Move ISO 14755 handling into x.c
> This does not seem X11-specific to me, can this be added/stay in st.c? Why
> was this separated?

This was moved into x.c because it used xwinid(), and doing so allowed
us to make the X window ID completely internal to x.c.

It also made sense to me to consider input methods as part of the user
interface rather than the terminal emulation. But I guess I could see
it in either place.

> In addition I think the fontconfig include can be (re)moved from st.c also
> right?
> #include <fontconfig/fontconfig.h>

Correct, along with a number of other includes. I have continued to
work on the refactoring at [1] (now up to -93 lines from master), and
this include has been removed.



Received on Wed Oct 04 2017 - 07:15:35 CEST

This archive was generated by hypermail 2.3.0 : Wed Oct 04 2017 - 07:24:21 CEST