Re: [hackers] [quark][PATCH] do not compare the port for triggering redirection

From: Laslo Hunhold <dev_AT_frign.de>
Date: Tue, 3 Apr 2018 01:07:33 +0200

On Mon, 2 Apr 2018 15:34:08 +0200
Josuah Demangeon <mail_AT_josuah.net> wrote:

Dear Josuah,

> This commit fix it by replacing the ':' before the port by '\0'.
> IPv6 addresses also have columns in the host name (RFC 2732):

thanks for cooking up the patch, but I wrote my own commit[0] in the
end due to a few reasons.
The first was that I actually want to do this cleanup early on during
parsing of the HTTP-header. Another is that I want to catch problems
early, like that the given port is empty and the enclosed address is
invalid (by form).
I gave you credit in the commit message of course. Thanks for your
input and working on this patch!

With best regards

Laslo Hunhold

[0]:https://git.suckless.org/quark/commit/?id=3ff82c514becd08922fcf9bc9f4870941650932a

-- 
Laslo Hunhold <dev_AT_frign.de>
Received on Tue Apr 03 2018 - 01:07:33 CEST

This archive was generated by hypermail 2.3.0 : Tue Apr 03 2018 - 01:12:28 CEST