Re: [hackers] [PATCH] [dwm] Make unset property fallback strings configurable

From: Eric Pruitt <eric.pruitt_AT_gmail.com>
Date: Tue, 3 Apr 2018 14:07:37 -0700

On Tue, Apr 03, 2018 at 07:55:53PM +0200, Silvan Jegen wrote:
> I tried the attached patch and it didn't work either. After creating
> a patch in this repo myself (and googling the error) I realized that
> your patch didn't have the "a/", resp. "b/" string prefix in the diff
> filenames. After adding these prefixes by hand (attached), the patch
> applied for me.
>
> How did you generate these patches? It's the first time I had this issue.

    ericpruitt_AT_sinister:~$ cd projects/dwm/
    ericpruitt_AT_sinister:dwm$ git format-patch HEAD^
    0001-Make-unset-property-fallback-strings-configurable.patch

However I relatively recently added "noprefix = true" to my Git
configuration i.e.

    [diff]
    noprefix = true
    algorithm = patience

It seems odd to me that Git would create a broken (or perhaps
backward-incompatible) patch because of that option. What version of Git
are you using? I'm running 2.11.0.

Eric
Received on Tue Apr 03 2018 - 23:07:37 CEST