On Mon, May 21, 2018 at 01:09:08PM +0200, Aaron Marcher wrote:
> David,
>
> Thank you very much for your great work!
> works great so far but I have just a few things for you to change.
>
> - Remove the "%" sign from the return
Do you mean in bprintf call, so like this: bprintf("%d", ...) ?
> - Move <stddef.h> in the Linux block as there is no other block to share
> code with
The problem is that util.h actually requires stddef.h (it uses size_t which is
is defined there). I think that include should eventually be moved there.
> - Add backlight_perc to config.def.h documentation (with acpi_video0 as
> example)
> - Add backlight_perc to README
>
> Also: for now we will add only OpenBSD support as FreeBSD is no port goal
> for version 1.
So even if I add support for FreeBSD you'll refuse it? I know the code, I've
already implemented I just need to get a FreeBSD laptop to ensure it still works
though :)
Regards,
--
David
Received on Mon May 21 2018 - 17:28:18 CEST