Re: [hackers] [slstatus][PATCH] Add flexible formatting to keyboard_indicators.

From: Ian Remmler <>
Date: Fri Jun 01 2018 - 23:15:08 CEST

On Fri, Jun 01, 2018 at 05:35:16PM +0200, Aaron Marcher wrote:
> You could also add something like "see keyboard_indicators.c for
> additional documentation".

That's reasonable.

> Additionally, for a minimum, add a comment for the argument and an example
> in config.def.h (like for the other components).

I had done that, but in config.h instead on accident. I'll add it.

> These can be simplified by creating one-liners for vars of the same type.

That is a deadly sin in our coding style at work, so my brain probably
skipped over that bit. :)

> Additionally, according we decided to add braces for blocks always, also for
> single line statements.

Oh, good! I prefer that. I'll update the patch this weekend.

	- Ian.
Received on Fri, 1 Jun 2018 16:15:08 -0500

This archive was generated by hypermail 2.1.8 : Fri Jun 01 2018 - 23:24:18 CEST