Re: [hackers] [sbase][PATCH] Add test framework with a test for tty(1)

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Sat, 7 Jul 2018 23:29:53 +0100

On Sun, Jul 08, 2018 at 12:12:08AM +0200, Mattias Andre wrote:
> On Sat, 7 Jul 2018 22:55:28 +0100
> Dimitris Papastamos <sin_AT_2f30.org> wrote:
>
> > This is too intrusive, what's wrong with using a shell script to test
> > the commands?
> >
> > The test framework is more complicated than most sbase commands.
> >
> > It would have been nice to discuss this in advance before writing a
> > 1000 line patch that might not get merged.
> >
>
> Writing all tests in shell isn't the best idea I think.
> This frameworks makes it easy to write test and it will
> tell you everything you need to know to figure out what
> failed. I believe that in the need this will reduce the
> amount of test code. There are things that are difficult
> to do in shell: for example create a terminal which is
> need to test tty(1). Look for example at the tests in
> https://github.com/maandree/base-util-tests, they aren't
> that nice, and they even require bash(1), it would be
> even worse with portable sh(1).

so what you are saying is that your shell code sucks so
it is better done in C?

sorry im not buying it, this is overkill
Received on Sun Jul 08 2018 - 00:29:53 CEST

This archive was generated by hypermail 2.3.0 : Sun Jul 08 2018 - 00:36:25 CEST