[hackers] Re: [st][PATCH v2 0/2] Cursor color handling

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Sat, 14 Jul 2018 12:54:25 +0200

On Sat, Jul 14, 2018 at 11:16:35AM +0200, Jules Maselbas wrote:
> Hi,
>
> I was looking for a way to make the cursor color behave the same as in
> xterm, by having it's color following the underlining text color. The
> first patch tries to simplify the existing code for cursor color handling.
>
> When st is in MODE_REVERSE all glyph including the cursor will have
> their color reversed by xdrawglyphfontspecs. However this is not the
> case for drawcol which is only used to draw specific shaped cursor.
>
> The second patch will make the cursor's color same as the fg color
> of the underlining text.
>
> I would like have your thoughts and feedbacks.
>
> Cheers.
>
> Change since v1:
> * Remove defaultcs and defaultrcs
>
> ---
>
> Jules Maselbas (2):
> Simplify cursor color handling
> Make cursor follow text color
>
> config.def.h | 2 --
> x.c | 32 ++++++++++++++------------------
> 2 files changed, 14 insertions(+), 20 deletions(-)
>
> --
> 2.18.0
>

Pushed, thanks :)

-- 
Kind regards,
Hiltjo
Received on Sat Jul 14 2018 - 12:54:25 CEST

This archive was generated by hypermail 2.3.0 : Sat Jul 14 2018 - 13:00:21 CEST