Re: [hackers] [st][PATCH] Let the user specify CPPFLAGS

From: Laslo Hunhold <dev_AT_frign.de>
Date: Thu, 10 Jan 2019 14:46:59 +0100

On Thu, 10 Jan 2019 14:39:39 +0100
Quentin Rameau <quinq_AT_fifth.space> wrote:

Dear Quentin,

> Nope, because this doesn't keep internal FLAGS.

ah I see, thanks for the heads up! :)

> The default behaviour is already to keep macros defined on the command
> line (without the need for environment macros + -e flag).
>
> Now the utility of keeping internal FLAGS can be discussed, I'm kind
> of in favor, but I wouldn't mind otherwise.

The approach with the make command line sounds interesting. How it's
handled is the maintainer's choice of course and maybe one could argue
for the patch for reasons of consistency. However, I also don't mind. :)

With best regards

Laslo

-- 
Laslo Hunhold <dev_AT_frign.de>

Received on Thu Jan 10 2019 - 14:46:59 CET

This archive was generated by hypermail 2.3.0 : Thu Jan 10 2019 - 14:48:24 CET