Re: [hackers] [ii] [PATCH] Fix traversal of addrinfo list

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Sun, 26 May 2019 15:39:51 +0200

On Sat, May 25, 2019 at 07:27:36PM -0700, Michael Forney wrote:
> Although the loop is executed once for every result, in each iteration
> it connects to the first result.
> ---
> ii.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ii.c b/ii.c
> index 6d2bd36..55d5f52 100644
> --- a/ii.c
> +++ b/ii.c
> _AT_@ -377,10 +377,10 @@ tcpopen(const char *host, const char *service)
> }
>
> for (rp = res; rp; rp = rp->ai_next) {
> - fd = socket(res->ai_family, res->ai_socktype, res->ai_protocol);
> + fd = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol);
> if (fd == -1)
> continue;
> - if (connect(fd, res->ai_addr, res->ai_addrlen) == -1) {
> + if (connect(fd, rp->ai_addr, rp->ai_addrlen) == -1) {
> close(fd);
> fd = -1;
> continue;
> --
> 2.20.1
>
>

Applied thanks :)

-- 
Kind regards,
Hiltjo
Received on Sun May 26 2019 - 15:39:51 CEST

This archive was generated by hypermail 2.3.0 : Sun May 26 2019 - 15:48:24 CEST