Re: [hackers] [PATCH v3 2/2][sbase] chgrp: parse gid if operand is not group name

From: Michael Forney <mforney_AT_mforney.org>
Date: Mon, 8 Jul 2019 14:09:04 -0700

On 2019-07-04, Richard Ipsum <richardipsum_AT_fastmail.co.uk> wrote:
> +
> + if (gid == -1)
> + usage();

I think this check is not necessary either, since estrtonum will error
if the specified value was negative.

I pushed with the check removed, and also a small style tweak (hope
you don't mind).

Thanks for the patch!
Received on Mon Jul 08 2019 - 23:09:04 CEST