[hackers] [st][PATCH] Remove explicit XNFocusWindow

From: Ivan Tham <pickfire_AT_riseup.net>
Date: Tue, 18 Feb 2020 23:28:47 +0800

XCreateIC ICValues default XNFocusWindow to XNClientWindow if not
specified, it can be omitted since it is the same.

From the documentation
https://www.x.org/releases/current/doc/libX11/libX11/libX11.html

> Focus Window
>
> The XNFocusWindow argument specifies the focus window. The primary
> purpose of the XNFocusWindow is to identify the window that will receive
> the key event when input is composed.
>
> When this XIC value is left unspecified, the input method will use the
> client window as the default focus window.

---
 x.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/x.c b/x.c
index 1f62129..48a6676 100644
--- a/x.c
+++ b/x.c
_AT_@ -1047,7 +1047,6 @@ ximopen(Display *dpy)
 		xw.ime.xic = XCreateIC(xw.ime.xim, XNInputStyle,
 		                       XIMPreeditNothing | XIMStatusNothing,
 		                       XNClientWindow, xw.win,
-		                       XNFocusWindow, xw.win,
 		                       XNDestroyCallback, &icdestroy,
 		                       NULL);
 	}
-- 
2.25.0

Received on Tue Feb 18 2020 - 16:28:47 CET