Re: [hackers] [hackers][new tool][gcrypt]

From: David Demelier <markand_AT_malikania.fr>
Date: Thu, 20 Feb 2020 10:14:47 +0100

Le 20/02/2020 à 09:59, Գասպար Վարդանյան a écrit :
> Hi! Gcrypt is a simple file encryption tool written in the C language,
> following Suckless’s philosophy.
> Please include this tool in your tools set.
> git repo: https://github.com/GasparVardanyan/gcrypt

Hi,

Few notes:

- Add a Makefile. It's the correct way to build something.
- Add a manual page please.
- Your gcrypt.h includes too much C headers that are not required for
the declarations provided here. Since you use size_t only <stddef.h>
would be required here.
- Macros in gcrypt.c... I don't think there is a real reason to
implement all that code in macros.

-- 
David
Received on Thu Feb 20 2020 - 10:14:47 CET

This archive was generated by hypermail 2.3.0 : Thu Feb 20 2020 - 12:00:29 CET