Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

From: Dave Blanchard <dave_AT_killthe.net>
Date: Tue, 1 Mar 2022 13:04:01 -0600

On Tue, 1 Mar 2022 14:15:03 +0100
Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:

> Hi David,

> It makes sense to me to add \033[1;5H. I'm not sure if \033[J is correct, it
> seems duplicate with XK_Home and XK_End also. Please test it properly.

I'm not sure if it's correct either; I'm not a terminal expert. It seems to work well on my end so far, but then again, it could break something. I still need to do a lot of reading and learning on ANSI escape codes.

> Negative bikeshed comments and exagerations ("total lack of comments") don't
> help in making the project better.

I didn't exaggerate anything. There are dozens of functions which have absolutely no comments whatsoever, with variable and function names which are extremely terse. As a non-terminal expert, it's not quite clear what half of the these things, and no, I'm not an idiot or a 'retard' as one other person put it.

> I'd happily apply a general patch which improves in making the appkey and
> cursorkey sequences more consistent.

Thanks for your relatively positive reply, which is nice to see in a such a sea of extreme negativity.

-- 
Dave Blanchard <dave_AT_killthe.net>
Received on Tue Mar 01 2022 - 20:04:01 CET

This archive was generated by hypermail 2.3.0 : Tue Mar 01 2022 - 20:12:35 CET