Re: [hackers] [dmenu][PATCHes] Fix truncation issues and improve performance

From: NRK <nrk_AT_disroot.org>
Date: Wed, 23 Mar 2022 00:26:24 +0600

On Tue, Mar 22, 2022 at 06:06:30PM +0100, Stein Gunnar Bakkeby wrote:
> With the first patch the text is still allowed to bleed into the right hand
> side padding as long as it fits.
>
> I worked around that by reducing w with 2 * lpad and adding lpad to x
> before returning.

Ahh, sorry my bad. I missed the "adding lpad to return" part.
Yeah, that seems to stop the prompt from getting cut off, but I as I
said given the variable name `lpad`, I guess that's probably
intentional.

Let's wait for someone to clarify what the intentional behavior is.

> I was thinking that the function drw_font_getexts might get removed, it was
> probably used for more in previous iterations.

I made the patches with the assumption that they could/would also be
integrated into libsl[0]. So I didn't remove anything or break the API.

[0]: https://git.suckless.org/libsl

- NRK
Received on Tue Mar 22 2022 - 19:26:24 CET

This archive was generated by hypermail 2.3.0 : Tue Mar 22 2022 - 19:36:36 CET