Re: [hackers] [dwm|dmenu|st][PATCH] strip the installed binary

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Mon, 2 May 2022 13:53:44 +0200

On Mon, May 02, 2022 at 01:48:05PM +0200, Quentin Rameau wrote:
> Hi Hiltjo,
>
> > I don't like this.
> >
> > I'd rather have it so the Makefile respects the system or package system CFLAGS
> > and LDFLAGS by default. Then someone can do: make CFLAGS="-Os" LDFLAGS="-s"
> > etc.
> >
> > LDFLAGS="-s" is practically the same as calling strip and stripping it.
> >
> > It is up to the distro package/ports maintainer to strip symbols (or not).
> > This can be an additional packaging step.
>
> Allright, that's valid to me (don't thank me for my meaningful addition
> to this conversation).
>
> > As a off-topic side-note I think we removing config.mk and just having the
> > Makefile is simpler too.
>
> I think that config.mk makes a bit more obvious (maybe)
> what is supposed to be configured,
> and what is part of the “stock” Makefile rules.
>
> This could also be a commented section within the Makefile though.
>

About config.mk I think its a good point. There no big reason to change it.

Thanks for your meaningful addition ;)

-- 
Kind regards,
Hiltjo
Received on Mon May 02 2022 - 13:53:44 CEST

This archive was generated by hypermail 2.3.0 : Mon May 02 2022 - 14:00:35 CEST