Re: [hackers] [dwm][PATCH] spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

From: Laslo Hunhold <dev_AT_frign.de>
Date: Sun, 31 Jul 2022 01:00:27 +0200

On Fri, 29 Jul 2022 18:26:04 -0500
explosion0mental_AT_gmail.com wrote:

Dear explosion0mental,

> when calling die and the last character of the string corresponds to
> ':', die() will call perror(). See util.c
>
> Cuz muh lines of code!1

> - fprintf(stderr, "dwm: execvp %s", ((char
> **)arg->v)[0]);
> - perror(" failed");
> - exit(EXIT_SUCCESS);
> + die("dwm: execvp '%s' failed:", ((char

as far as I can tell this is not correct, given the program exits with
EXIT_SUCCESS, not EXIT_FAILURE.

With best regards

Laslo
Received on Sun Jul 31 2022 - 01:00:27 CEST