Re: [hackers] [st][PATCH] fix BadMatch error when embedding on some windows

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Thu, 8 Aug 2024 15:29:33 +0200

Hi,

On Wed, Aug 07, 2024 at 11:55:59PM -0300, Lucas de Sena wrote:
> When embedded, st fails with BadMatch error if the embedder's window has
> non-default colormap/depth/visual. This commit fixes that by creating
> st's window inside root and then reparent it into embedder.
>
> The reference window for dc.gc is also changed to match root's visuals.
>
> A similar commit had been made for dmenu[1].
> See this issue[2] on github for context.

With a fast review, this seems right to me.

Regards,
Received on Thu Aug 08 2024 - 15:29:33 CEST