Re: [hackers] [sbase][PATCH] cp: add -i flag

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.net>
Date: Sun, 20 Apr 2025 09:12:37 +0200

Hi,

On Sat, Apr 19, 2025 at 11:25:15AM +0000, NRK wrote:
> At a glance this looks okay, aside from what Quentin mentioned about
> POSIX disallowing trimming leading chars.
>
> Also it seems like your mail client is messing up the indentation. It's
> better to just attach the patch as a file. But I'd wait until Roberto
> responds to Quentin's mail on the POSIX issue before sending again.

Indeed. It seems that POSiX mandates to have a y/Y at the beginning of the
line, but they open the door for ambiguous responses. I would take the simpler
solution and just check for y/Y at the beginning of the line.

The best way to submit patches is using git-send-email or you can use
git format-patch -M and include it in the body. If your mail client
fucks with spaes and tabs, then just attach it as NRK said.

Regards,
Roberto Vargas
Received on Sun Apr 20 2025 - 09:12:37 CEST