Re: [hackers] [surf] [PATCH] Introduce JavaScriptMarkup option (limit site JS w/o user JS)

From: Artyom Bologov <mail_AT_aartaka.me>
Date: Sun, 20 Apr 2025 21:49:27 +0400

Quentin,

>> > I think that's fine, as this was kind of happening before anyway,
>> > and if we can remove that IPC between main and ext through
>> > ugly glib, the better.
>>
>> Not sure I get this one. Why glib?
>
> Because of the need for integrating into the main gtk loop,
> look at the whole GIO madness (which doesn't work well too)
> from pageusermessagereply().

Oh I see now!

> Maybe, but this is mostly already part of the webkitgtk documentation.
> We could keep a skeleton on the side, but as a second time patch,
> making clear we remove the main surf webext, while having a something
> like a webext-example.c on the side.

Maybe just clean up the webext-surf.c and retain it in the Makefile?
Much line config.h, it's there to be extended, even if doing nothing by
default. I'm okay with webext-example.c idea too, though.

>> > - Maybe it's not really useful to disable JavaScript (the original
>> > one) entirely as it's needed for the core feature of being able to
>> > scroll. Instead, we could substitute it for JavaScriptMarkup
>> > directly.
>>
>> This is my doubt too. I opted for a separately toggled option because
>> it seems useful (to a paranoid like me) to have a master override like
>> JavaScript setting in addition to *-Markup one. But that also means
>> that one can accidentally disable scrolling, which is not that
>> intuitive.
>>
>> But the course of action with substituting JavaScript for
>> JavaScriptMarkup in user-facing code (-Ss option, config examples
>> maybe) seems most sane to me too.
>
> Yeah, what could be done is to do the substitution regarding
> the option handling and toggling,
> while keeping both options for those who actually want it.
>
> Then what could be useful is some comment somewhere,
> eihter in the config.def.h directly, or the README.

I've gone with a separate CLI option (-Jj,) and a note in config.def.h,
find the full patch (including the original one) attached.


Received on Sun Apr 20 2025 - 19:49:27 CEST