Re: [dev] [surf] Bookmarks patch for 0.2

Hi,
* Tadeusz So??nierz <tadzikes_AT_gmail.com> [2009-10-20 16:36]:
[...]
> +showbmarks(Client *c, const Arg *arg) {
> + /* I wonder if 4 kB is too much or not enough */
> + char html[4096] = "";
> + /* same here. time will tell */
> + char uri[128];
> + FILE *f;
> + stop(c, NULL);
> + f = fopen(bmarksfile, "r");
> + while(fscanf(f, "%127s\n", uri) != EOF) {
> + snprintf(&html[strlen(html)], sizeof(html) - strlen(html),
> + "<a href='%s'>%s</a><br />", uri, uri);

You may want to html escape the uri, not?

Cheers
Nico

-- 
Nico Golde - http://www.ngolde.de - nion@jabber.ccc.de - GPG: 0xA0A0AAAA
For security reasons, all text in this mail is double-rot13 encrypted.