Re: [dev] [9base] patch to build on OpenBSD

On Sun, Jul 18, 2010 at 06:26:55PM +0200, Sebastian Liem wrote:
>diff -r 09af6227574f ed/ed.c
>--- a/ed/ed.c Fri Jun 04 11:44:25 2010 +0100
>+++ b/ed/ed.c Sun Jul 18 17:35:53 2010 +0200
>@@ -121,7 +121,7 @@
> void setwide(void);
> void squeeze(int);
> void substitute(int);
>-char* _mktemp(char *as);
>+char* __mktemp(char *as);
>
> Rune La[] = { 'a', 0 };
> Rune Lr[] = { 'r', 0 };
>@@ -162,7 +162,7 @@
> globp = Lr;
> }
> zero = malloc((nlall+5)*sizeof(int*));
>- tfname = _mktemp(tmp);
>+ tfname = __mktemp(tmp);
> init();
> setjmp(savej);
> commands();

This really isn't a good idea. Most implementations of libc use
obscene numbers of symbols prefixed with __, especially glibc
which seems to define a __ version of every damn symbol. It's
safer to go with the standard mymktemp or p9p's p9mktemp.

-- 
Kris Maglione
The key to performance is elegance, not battalions of special cases.
	--Jon Bentley and Doug McIlroy