Re: [dev] Re: dwm puzzle [fixed; with blame]

From: pancake <pancake_AT_youterm.com>
Date: Sat, 11 Sep 2010 21:58:52 +0200

Thats weird..only possible explanation is that any of those functions is a macro. Which is not the case i think (didnt check the sauce). When using macros it is recommended to explicitly put parenthesis when using any of the parameters of it. Else it can result on shity bugs like this.

Btw. If any of those functions is a macro. I would encourage to rename it in uppercase.

--pancake

----- Original message -----
> On Sat, Sep 11, 2010 at 01:35:10PM -0400, Peter John Hartman wrote:
> > Hi,
> >
> > Before an upgrade to hg tip last month (long overdue, maybe about a
> > year overdue) firefox and open  office used to "behave properly": if
> > I'm in tile mode and fire up firefox, e.g., it tiles as well.  But
> > now, after the upgrade, both firefox and open office behave like
> > elitists: not only do they not tile in tile mode (they sit on top)
> > they don't allow me to do focusstack either to flip to other things
> > under the stack.  Hence, MODKEY t, m, and the  j and k don't work.  I
> > can make firefox behave if I hit F11 (oddly enough), but nothing I can
> > do can get open office to behave.
> >
> > I have no Rules in my Rules section of config.h and I verified that
> > this is the same even with a vanilla config.def.h as my config.h.
> > Suggestions?
>
> Thanks to Anselm, we figured out who to blame at least: the compiler.
> This fixes it:
>
> diff -r 050d521d66d8 -r c361034c5a1c dwm.c
> --- a/dwm.c        Tue Aug 24 13:13:20 2010 +0100
> +++ b/dwm.c        Sat Sep 11 19:00:18 2010 +0000
> @@ -799,7 +799,7 @@
>                                unfocus(selmon->sel, True);
>                                selmon = m;
>                }
> -            focus(wintoclient(ev->window));
> +            focus((wintoclient(ev->window)));
>  }
>
> But evidently that's odd. 
> gcc version 4.4.3 (Gentoo 4.4.3-r2 p1.2) 
>
> I use the default config.mk (without XINERAMA stuff) and config.h.
>
> In any case, that fixes the bug and now openoffice and firefox behave.
>
> Thoughts?
> Peter
>
Received on Sat Sep 11 2010 - 21:58:52 CEST

This archive was generated by hypermail 2.2.0 : Sat Sep 11 2010 - 22:00:04 CEST