Re: [dev] [dmenu] [patch] add xft and fix possible memory leak in version 4.2.1

On 21 November 2010 06:31, Wolf Tivy <wtivy1_AT_my.bcit.ca> wrote:
>> 2) dmenu v4.2.1 appears to be leaking memory. It is missing the
>> routines to teardown/cleanup memory structures present in previous
>> versions. This patch also adds them.
>
> dmenu doesn't run long and the OS frees all the memory used
> by the process. Once it's decided that the process is going to quit,
> failing to free memory is irrelevant.
>
> If it leaks data created by handling events, I can see that being trouble,
> but except for these I see no reason dmenu should ever call free.

Well for clarity and consistency reasons I prefer if dmenu cleans up
all resources acquired at the end. So that cleanup() was removes looks
more like a bug to me and thanks to Dan for pointing this out.

As for the XFT bits I will have a look how to integrate them probably
as a different draw.c altogether. I need to analyse the impact. There
were plans to also have a cairo based draw.c probably at some point
(also shared with dwm).

Cheers,
Anselm
Received on Sun Nov 21 2010 - 09:11:39 CET