Re: [dev] [PATCH] dmenu: Add commandline-options to determine Xinerama-screen

From: Connor Lane Smith <cls_AT_lubutu.com>
Date: Wed, 11 May 2011 12:39:16 +0100

Hey Rob,

On 11 May 2011 12:01, Rob <robpilling_AT_gmail.com> wrote:
> Sorry to thread-dig here, but I've had trouble with dmenu recently and
> traced it to this patch. The XCreateWindow call would fail because mw
> would be zero. I'm unsure why, but this problem only happened when
> Firefox or OpenOffice were focussed. Anyway, I've sorted it, the patch
> caused dmenu to access past the end of the info array and a quick bounds
> check fixes it.

I think this was caused by the given '-m' not being present. I've
applied a patch which should fix this, since it falls back to the
mouse if the '-m' isn't there. Could you confirm whether it works?

If it doesn't it's a weird corner case (which must have existed prior
to this patch), and we'll have to just fall back to the last monitor
like you suggested.

Thanks,
cls
Received on Wed May 11 2011 - 13:39:16 CEST

This archive was generated by hypermail 2.2.0 : Wed May 11 2011 - 13:48:03 CEST