Re: [dev] [tabbed] how focusing is handled

On Thu, 22 Sep 2011, Roman Z. wrote:

> On Wed, Sep 21, 2011 at 09:48:11PM +0200, Roman Z. wrote:
>> Currently, if you run a program in tabbed and move the mouse away
>> from that window, the program will not respond anymore.
>>
>> Since this is much like how X behaves when you run no window manager,
>> I've been looking in dwm code for solutions to this problem but to no
>> avail. Maybe you can tell me what part of dwm handles this and I can
>> apply it to tabbed? Or do you have other ideas?
>>
>> To reproduce:
>> 1. open xterm in tabbed. This hasn't worked for me with the newest
>> version, I use revision 142.
>> 2. put the mouse inside the tabbed window and type "a". It works.
>> 3. move the mouse out of the window and type "a". Nothing happens.
>
> One solution is to revert the changeset 138. It has the commit
> message: "removing XSetInputFocus() calls to be ICCCM compliant again.
> Thanks to Thomas Adam".
>
> Please consider reverting this changeset in upstream since you now
> know that it introduced a bug.

Confirming that reverting 138 worked here, too:

changeset: 138:5eff0bc41822
user: Enno Boland (tox) <tox_AT_s01.de>
date: Mon Apr 26 22:30:27 2010 +0200
summary: removing XSetInputFocus() calls to be ICCCM compliant again. Thanks to Thomas Adam fixes tabbed for me, too, under dwm.

It'd also be nice if the 'command' of 'tabbed [-d] [-v] command' were
optional. Not sure how hard that'd be. It was weird to have to test it
differently based on what version I was testing. I'll look at it later
(instead of just complaining) if someone doesn't do it first.

-- 
Best,
Ben