Re: [dev] [surf] patch to remove resizing if small

From: pancake <pancake_AT_youterm.com>
Date: Mon, 11 Jun 2012 17:04:34 +0200

On 06/11/12 16:12, Nick wrote:
> Quoth pancake:
>> surf.c: In function ‘gotheaders’:
>> surf.c:337:11: warning: variable ‘uri’ set but not used
>> [-Wunused-but-set-variable]
> Good spot. My gcc doesn't catch that, but you're right, it is
> unused. I'm attaching a patch that removes use of that variable,
> plus removes a couple of unused arguments from functions (found with
> -Wextra).
didnt knew about this -Wextra flag, nice one!

the patch looks fine to me, so i'll commit it too.
>> surf.c: At top level:
>> surf.c:800:1: warning: ‘eval’ defined but not used [-Wunused-function]
> I think eval is probably useful to keep as a hook, though. For
> config.h funkiness or something else someone wants to do. I don't
> have strong feelings on the matter, though.
>
Yep, maybe someone is going to use it, so it's ok if we leave it here.

Anyway, i have noticed that META-h means go back and scroll left, which
is kinda weird, because i dont think anyone is going to scroll left few
pixels
and then go back.. there are other dupped keybindings. we should fix that.

proposals?

--pancake
Received on Mon Jun 11 2012 - 17:04:34 CEST