Re: [dev] Adding utmpx stuff

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Tue, 09 Oct 2012 19:09:36 +0200

Hello.

On Tue, 09 Oct 2012 19:09:36 +0200 "Roberto E. Vargas Caballero" <k0ga_AT_shike2.com> wrote:
> Hello,
>
> This patch adds utmpx support in st, which means that st sessions
> will be visible using who or, who is the correct behaviour of a terminal
> emulator, but this means that the binary needs have setgid, which is
> something we have to thing carefully.
>
> Other important about this patch is the portability of it. I have
> used the POSIX definitions, but as far as I know, there are some BSD that
> don't support very well this functions (specially OpenBSD). There are
> different solutions for this:
>
> - A hell of ifdef inside in st.c
> - A pty.c where all this portability stuff is present.
> - A compat file (or one for each problematic System), where
> this interfaces are adapted.

This patch is fixing something st shouldn’t do. In my environment all
the environment variables you propose to add are set. That’s something
the shell should do and not the terminal emulator. A terminal emulator
should be neutral to this. Sorry, but I think you are fixing something
at the wrong place in your environment. If this metadata for good old
style tty’s is needed, well, try to fix this in the existing operating
systems.


Sincerely,

Christoph Lohmann
Received on Tue Oct 09 2012 - 19:09:36 CEST