On Mon, Feb 04, 2013 at 10:09:25PM +0100, markus schnalke wrote:
> [2013-02-04 20:57] v4hn <me_AT_v4hn.de>
> > On Mon, Feb 04, 2013 at 11:46:51PM +0800, Chris Down wrote:
> >> SNOTES_EDITOR=${VISUAL:+xterm -e $VISUAL}
> >> : "${SNOTES_EDITOR:=${EDITOR:-vim}}"
> >
> > That would make the config do more than it is supposed to.
> > I agree that it makes sense to respect $VISUAL though.
> > I now changed the line to
> >
> > SNOTES_EDITOR=${VISUAL:-xterm -e vi}
> >
> > to meet that requirement.
>
> On my system VISUAL is set to `vi', which is a common situation.
> Your code assumes that VISUAL contains a graphical editor. Thus
> the setup breaks for me AFAICS.
>
I see. Thanks for note. I've changed it to the following now,
which should work for all reasonable setups.
If this doesn't work for someone, honestly, I couldn't care less.
It's a default, not the final truth.
SNOTES_EDITOR="${EDITOR:+xterm -e $EDITOR}"
SNOTES_EDITOR="${SNOTES_EDITOR:-xterm -e vi}"
v4hn
- application/pgp-signature attachment: stored
Received on Tue Feb 05 2013 - 00:54:46 CET